ANDROAPP-5486-mobile-ui-Bottom-Sheet-Shell #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavimolloy
force-pushed
the
ANDROAPP-5486-mobile-ui-Bottom-Sheet-Shell
branch
from
e119f14 to
f421c18
Compare
andresmr
reviewed
Sep 14, 2023
andresmr
reviewed
Sep 14, 2023
| @@ -14,6 +14,7 @@ enum class Components(val label: String) { | |||
| INPUT_NUMBER("Input Number"), | |||
| INPUT_LETTER("Input Letter"), | |||
| BOTTOM_SHEET_HEADER("Bottom Sheet Header"), | |||
| BOTTOM_SHEET("Bottom Sheet "), | |||
There was a problem hiding this comment.
same here, what about merge it with the header?
| @@ -122,6 +122,28 @@ fun IconButton( | |||
| } | |||
| } | |||
|
|
|||
| @Composable | |||
| fun BottomSheetIconButton( | |||
There was a problem hiding this comment.
Are we reusing this button?
There was a problem hiding this comment.
this button will be reused for all bottomSheet variations but I could probably make it internal
designsystem/src/commonMain/kotlin/org/hisp/dhis/mobile/ui/designsystem/theme/TextColor.kt
Show resolved
Hide resolved
andresmr
approved these changes
Sep 14, 2023
xavimolloy
force-pushed
the
ANDROAPP-5486-mobile-ui-Bottom-Sheet-Shell
branch
from
f421c18 to
4e1a21f
Compare
DavidAparicioAlbaAsenjo
approved these changes
Sep 14, 2023
andresmr
approved these changes
Sep 15, 2023
…iss, styles modified
…emove unnecessary dependencies
xavimolloy
force-pushed
the
ANDROAPP-5486-mobile-ui-Bottom-Sheet-Shell
branch
from
1a382c6 to
a23b1fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.